Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager, computing prefs dialog: Fix bug where the "In use means..." value mysteriously showed up in the "suspend when non-BOINC..." field. #5269

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

davidpanderson
Copy link
Contributor

The problem was that wxWidgets' ToDouble(&x) returns an error (which we weren't checking for)
and doesn't modify x if the string is empty.
So we were getting the value from a previous field.

Solution: set x to zero before each such call.

Fixes the bug reported in #5266

Fix bug where the "In use means..." value mysteriously showed up
in the "suspend when non-BOINC..." field.

The problem was that wxWidgets' ToDouble(&x) returns an error
(which we weren't checking for) and doesn't modify x
if the string is empty.
So we were getting the value from a previous field.

Solution: set x to zero before each such call.
@AenBleidd
Copy link
Member

AenBleidd commented Jun 13, 2023

@davidpanderson, please fix trailing whitespaces issue:

Found files with errors:
./clientgui/DlgAdvPreferences.cpp:573
./clientgui/DlgAdvPreferences.cpp:645
To fix errors run locally:
	python3 ci_tools/trailing_whitespaces_check.py . --fix

@Vulpine05
Copy link
Contributor

I tested this and it looks like it fixed the problem. Thanks!

@AenBleidd AenBleidd merged commit 9a63963 into master Jun 16, 2023
40 checks passed
@AenBleidd AenBleidd deleted the dpa_prefs7 branch August 15, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants