Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Add alert if idle time to resume computing is greater than idle time to suspend computing #5270

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

Vulpine05
Copy link
Contributor

Partially fixes #4939

Description of the Change
When global preferences are read in the client, a check is in place to see if the idle time to resume computing is greater than the idle time to suspend computing, but only if CPU or GPU computing is to be suspended when the computer is in use. If this condition is true, CPU or GPU computing could be suspended indefinitely regardless of the activity of the computer. This check will send an alert to the user to make them aware.

Alternate Designs
Previous ideas were discussed in #4960, but this was favored since it did not modify preferences. Thank you to @AenBleidd and @davidpanderson for the feedback!

Release Notes
[Client] Alert added if idle time to resume computing exceeds idle time to suspend computing.

…ter than idle time to suspend computing.

Partial fix to BOINC#4939
@Vulpine05
Copy link
Contributor Author

Apologizes, I meant to include screen captures of what the alert looks like. Screen captures are in 1920x1080. I'm open to suggestions to making the alert shorter and still informative.

Under Notices:
image

In the Event Log:
image

@davidpanderson
Copy link
Contributor

I'd shorten it to:

Preference settings don't allow computing (9.00 > 8.00). Please review.

The numbers tell the user which prefs we're talking about.

@AenBleidd
Copy link
Member

I agree: the message should be definitely shorter than now, and shows which numbers are not correct.

If statement was missing that suspend_if_no_recent_input has to be enabled.  Also revised message to be shorter.
@Vulpine05
Copy link
Contributor Author

Great suggestion, thank you! See revised:
image

image

I also noticed I missed in my logic that suspend if no recent input had to be enabled, too. That is fixed in the latest commit.

Hmm... @davidpanderson, I see in the event log that the two times have different significant digits, %.1f and %f, respectively. I used %.2f for the alert. Do you think we should have these match?

@davidpanderson
Copy link
Contributor

It might be good to use %.2f for minutes, everywhere.

@Vulpine05
Copy link
Contributor Author

It might be good to use %.2f for minutes, everywhere.

Fixed.

@davidpanderson davidpanderson merged commit 21b5a66 into BOINC:master Jun 15, 2023
40 checks passed
@Vulpine05 Vulpine05 deleted the Vulpine05-4939_Client_V2 branch June 16, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"In Use" and "Not In Use" suspension preferences could prevent computing indefinitely
3 participants