Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction for issue #5297 #5302

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

LLyaudet
Copy link
Contributor

@LLyaudet LLyaudet commented Jul 3, 2023

Fixes #5297

Description of the Change
Just reference all the strings for amicable numbers project as is already done for some other projects

Release Notes
Added translations strings for Amicable numbers project.

@LLyaudet
Copy link
Contributor Author

LLyaudet commented Jul 3, 2023

See the initial issue that was wrongly rejected here:
#5297
And see the discussion I had with the maintainer of Amicable numbers project here:
https://sech.me/boinc/Amicable/forum_thread.php?id=274

@LLyaudet
Copy link
Contributor Author

LLyaudet commented Jul 3, 2023

I checked the last commit before mine that added strings to translate for the project WCG dfcb624.
It did not update the po files.
Let me know if I should nevertheless regenerate the po files and add it in the PR.
Thanks :)

@AenBleidd
Copy link
Member

.po files are generatee by project maintainers, so you don't need to do that

Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AenBleidd AenBleidd merged commit 55084fc into BOINC:master Jul 3, 2023
@LLyaudet
Copy link
Contributor Author

LLyaudet commented Jul 4, 2023

Thanks :)

@LLyaudet
Copy link
Contributor Author

LLyaudet commented Jul 4, 2023

@AenBleidd Do you know when you will run this script, please ?
https://github.com/BOINC/boinc/blob/master/locale/update_templates.sh
When you do, I'll translate what is missing on transifex.
It would be great if I can do it this week-end or sooner :)

@AenBleidd
Copy link
Member

This will be done 2-4 weeks before the preparation for the next alpha release. You might expect this to happen closer to the end of this month.

@LLyaudet
Copy link
Contributor Author

LLyaudet commented Jul 4, 2023

Thanks :) I add an alert in my smartphone for the end of the month then.

@AenBleidd
Copy link
Member

AenBleidd commented Jul 4, 2023 via email

@AenBleidd
Copy link
Member

@LLyaudet, localization templates have been updated on the Transifex. Please take a look

@LLyaudet
Copy link
Contributor Author

Hello @AenBleidd :)

Thanks for the update :)

The pot file looks good with some new strings:
https://github.com/BOINC/boinc/blob/d674ab3c893f90123fa15686439af8f591280227/locale/templates/BOINC-Manager.pot#L2509C13-L2509C18

I checked Transifex and the new strings for BOINC have already been translated by someone faster than me :)
Some strings are still to translate for Einstein@Home, and I translated one.
Some people are actively translating them right now.
It should be 100 % translated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing strings to translate in French po files
2 participants