-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manager] Add button in event log to display only alerts (errors) #5313
Conversation
This adds a wxButton to the window to allow the user to filter the event log by alerts.
New bools added to be used to determine if filtering by alert/errors is active and if the filtering has changed.
Consolidates code used multiple times in OnErrorFilter and OnMessagesFilter.
New function created to filter errors (alerts) when alert filter button is used.
Additions or modifications to either maintain functionality of the existing function and/or to include functionality for filtering by alerts.
Prevents the filter alerts button from being cut off when the window is reduced in width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. It looks great.
Please fix the names and also remove trailing workspaces (see the failed CI check).
Nice! |
I'm fine with "Show only alerts", but I'm concerned "show all" may imply that all filtering is being reset. All it does is reset the filter for message priority. This allows the user to filter by a project, and then toggle a filter for alerts if they want. |
I think it would be clear - the user clicks "show only alerts" |
@davidpanderson, fixed the button text as requested. Additionally, I had adjust the minimum width for the window to account for the old button text; I have not reverted it since it is no longer needed. |
Fixes #4258
Description of the Change
Button added to the event log window to filter out alerts (aka errors). Button toggles to display only alerts and to all message types. Functionality was also added to the "show all messages" button as well. For example, if messages are filtered by a project and then the alert button is clicked, then only alerts for that specific project are displayed.
Screen shots:
New button added:
![New button](https://private-user-images.githubusercontent.com/58096400/255164378-c98e9b0e-6253-4c34-9e29-a4681143023c.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5OTAyODksIm5iZiI6MTcyNTk4OTk4OSwicGF0aCI6Ii81ODA5NjQwMC8yNTUxNjQzNzgtYzk4ZTliMGUtNjI1My00YzM0LTllMjktYTQ2ODExNDMwMjNjLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE3Mzk0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxZjJjODNlODZmMWMxNTExMmE5YTE3NzI0NTRkNDI4OTBjYmZlOTliZTEzYjI5OGFmMzRkYWFjNjljZmVhNzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1W_e0QeBdv1Oxnwy3G6NWZ4EPwPNcM0PUkg-_FAeONw)
When alerts are filtered:
![Alerts filtered](https://private-user-images.githubusercontent.com/58096400/255164398-9e26def8-e922-4c9f-8c9e-c607c80f6e07.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5OTAyODksIm5iZiI6MTcyNTk4OTk4OSwicGF0aCI6Ii81ODA5NjQwMC8yNTUxNjQzOTgtOWUyNmRlZjgtZTkyMi00YzlmLThjOWUtYzYwN2M4MGY2ZTA3LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE3Mzk0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmNGEyMzA0ZmIwY2JhZTIwNGNhZTkyNGVhYTMyYzEzMzM4MDkxZmQzMjUzMGY4Yjg0MjdjMGI3NzIzMWUxYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UnFdYn-_300AY52TOHF0FhdacCOaQKz1T5W1OYO7WGg)
When alerts and a project are filtered:
![Alert and project filtered](https://private-user-images.githubusercontent.com/58096400/255164509-8b3a2899-1c25-4ad9-b525-e659b98617c2.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5OTAyODksIm5iZiI6MTcyNTk4OTk4OSwicGF0aCI6Ii81ODA5NjQwMC8yNTUxNjQ1MDktOGIzYTI4OTktMWMyNS00YWQ5LWI1MjUtZTY1OWI5ODYxN2MyLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE3Mzk0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3OGFkYmZlMmQ5MDkzMzZiYjVjZGQyZTgyNDdhYmYxMTZlYzE2ODA5OWQ1MTNlOTc5ZDRjN2FjYmU0YWZjNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Kb61WGve_rtLE6W2yHr2rDNPRLG9YzxgYIj4KU4sWgw)
Alternate Designs
None considered.
Release Notes
Add button in event log to display only alerts.