Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manager] Add button in event log to display only alerts (errors) #5313

Merged
merged 10 commits into from
Jul 22, 2023

Conversation

Vulpine05
Copy link
Contributor

Fixes #4258

Description of the Change
Button added to the event log window to filter out alerts (aka errors). Button toggles to display only alerts and to all message types. Functionality was also added to the "show all messages" button as well. For example, if messages are filtered by a project and then the alert button is clicked, then only alerts for that specific project are displayed.

Screen shots:

New button added:
New button

When alerts are filtered:
Alerts filtered

When alerts and a project are filtered:
Alert and project filtered

Alternate Designs
None considered.

Release Notes
Add button in event log to display only alerts.

This adds a wxButton to the window to allow the user to filter the event log by alerts.
New bools added to be used to determine if filtering by alert/errors is active and if the filtering has changed.
Consolidates code used multiple times in OnErrorFilter and OnMessagesFilter.
New function created to filter errors (alerts) when alert filter button is used.
Additions or modifications to either maintain functionality of the existing function and/or to include functionality for filtering by alerts.
Prevents the filter alerts button from being cut off when the window is reduced in width.
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. It looks great.

Please fix the names and also remove trailing workspaces (see the failed CI check).

clientgui/DlgEventLog.h Outdated Show resolved Hide resolved
@davidpanderson
Copy link
Contributor

Nice!
Please change text to "Show only alerts" and "Show all"
(the tooltips can be longer)

@Vulpine05
Copy link
Contributor Author

Nice! Please change text to "Show only alerts" and "Show all" (the tooltips can be longer)

I'm fine with "Show only alerts", but I'm concerned "show all" may imply that all filtering is being reset. All it does is reset the filter for message priority. This allows the user to filter by a project, and then toggle a filter for alerts if they want.

@davidpanderson
Copy link
Contributor

I think it would be clear - the user clicks "show only alerts"
and the button changes to "show all".
The tooltip would say something like "show both alerts and non-alert messages".

@Vulpine05
Copy link
Contributor Author

@davidpanderson, fixed the button text as requested. Additionally, I had adjust the minimum width for the window to account for the old button text; I have not reverted it since it is no longer needed.

image

image

@AenBleidd AenBleidd merged commit a8465c5 into BOINC:master Jul 22, 2023
33 of 37 checks passed
@Vulpine05 Vulpine05 deleted the Vulpine05-4258 branch July 22, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error filter.
3 participants