server (all components that use DB): don't use MYSQL_OPT_RECONNECT if deprecated #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecated Starting with 8.0.34, the MySQL reconnection option is deprecated, and using it produces a warning message. So don't use it with MySQL 8.0.34 and later. Note: this means that if the MySQL server dies, long-running programs like the transitioner will stop working, and you'll have to stop/start the project. If this proves to be a problem, we could add our own reconnect logic.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5342 +/- ##
============================================
- Coverage 10.87% 10.87% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 36058 36059 +1
Branches 8334 8335 +1
============================================
Hits 3920 3920
- Misses 31744 31745 +1
Partials 394 394
|
AenBleidd
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 8.0.34, the MySQL reconnection option is deprecated, and using it produces a warning message.
So don't use it with MySQL 8.0.34 and later.
Note: this means that if the MySQL server dies,
long-running programs like the transitioner will stop working, and you'll have to stop/start the project.
If this proves to be a problem, we could add our own reconnect logic.
Fixes #5341