Client: add sporadic app feature #5385

davidpanderson · 2023-10-03T21:06:46Z

See https://github.com/BOINC/boinc/wiki/Sporadic-Applications
Fixes #5358

This should have no effect if no sporadic apps are present.

Passes basic tests using a simple sporadic app.
Additional testing/debugging will be needed when/if there are real sporadic apps.

- call sporadic init and poll functions - add sporadic_debug log flag - finish sporadic test app (samples/sporadic/sporadic.cpp) - sporadic jobs are always run (like NCI) - projects can now have a mix of regular, non CPU intensive, and sporadic apps. This mix can change over time. Because of this, there is longer a project-wide NCI flag. Projects have to tag individual apps as NCI. I don't think this affects any current projects. - fix potential timing problem in client/app comm by introducing 2.5 sec 'ignore_until' period - API: fix bug in parsing hearbeats - Add member functions of RESULT, ACTIVE_TASK etc. so you can get APP attributes like cpu_intensive, sporadic etc. without traversing pointers - --app_test feature: put init_data.xml in slots/app_test, otherwise app will run in standalone mode

but not tested. - Add code to SPORADIC_RESOURCES to check and reserve coprocs - Subtract sporadic resources before scheduling regular jobs - Move SPORADIC_RESOURCES to coproc_sched.h, making it visible to other code - Change 'have_sporadic' to 'have_sporadic_app'; we use the word 'sporadic' for network connections too

AenBleidd · 2023-10-04T11:19:28Z

@davidpanderson, currently the build is broken for Windows because of the new file added.
Let's handle this offline (will write an email to you with the explanations what should be fixed).
I'll put this PR to draft right now to prevent it from being merged and to not block the current master branch.

CharlieFenton

This is far outside my area of expertise so I don't feel I can review it other than to say that it builds without warnings or errors on my Mac.

davidpanderson · 2023-10-04T22:56:54Z

The new code for sporadic apps never gets called unless there are sporadic apps; this should be easy to check. So it shouldn't break anything. We can't fully debug it until we have a real sporadic app; the distributed AI people will hopefully have one soon.

…

-- D

On Wed, Oct 4, 2023 at 4:26 AM CharlieFenton ***@***.***> wrote: ***@***.**** approved this pull request. This is far outside my area of expertise so I don't feel I can review it other than to say that it builds without warnings or errors on my Mac. — Reply to this email directly, view it on GitHub <#5385 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHQVAKBBLJBOTPZRQV32VDX5VBX5AVCNFSM6AAAAAA5RS3W26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJXGMYDAMBSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

…a_sporadic

codecov · 2023-10-05T00:44:14Z

Codecov Report

Merging #5385 (52daa40) into master (44295c1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5385      +/-   ##
============================================
- Coverage     10.87%   10.86%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           279      279              
  Lines         36061    36073      +12     
  Branches       8335     8339       +4     
============================================
  Hits           3920     3920              
- Misses        31747    31759      +12     
  Partials        394      394

Files	Coverage Δ
api/boinc_api.h	`0.00% <ø> (ø)`
lib/app_ipc.h	`0.00% <ø> (ø)`
lib/cc_config.h	`0.00% <ø> (ø)`
lib/common_defs.h	`0.00% <ø> (ø)`
lib/cc_config.cpp	`0.00% <0.00%> (ø)`
api/boinc_api.cpp	`0.00% <0.00%> (ø)`

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

AenBleidd · 2023-10-05T16:28:31Z

I have added this new app to the Windows MSVC project.
However, some additional changes are required to build this new app for linux and Android on our CI.
I'll handle this during next two days.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

CharlieFenton · 2023-10-06T00:16:33Z

Add sporadic sample app to the linux and android CI pipelines

My understanding is that this is not actually a sample / example but a test application. It is unclear how it is to be used. Perhaps @davidpanderson can clarify this.

AenBleidd · 2023-10-06T00:24:33Z

@CharlieFenton, I got a different impression. But I might be wrong here, of course

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

AenBleidd · 2023-10-06T00:53:48Z

@CharlieFenton, we have most of our samples built on the CI for MacOS.
Do we need to build sporadic sample all as well?

CharlieFenton · 2023-10-06T00:55:50Z

The first line of samples/sporadic/sporadic.cpp is
// test sporadic app

davidpanderson · 2023-10-06T01:27:42Z

The apps in samples/ have various purposes.
Some are for direct use by projects (wrapper, vboxwrapper).
Others are templates for projects (nvcuda).
Others are for testing the API (sleeper, worker, sporadic)

CharlieFenton · 2023-10-06T06:21:50Z

Wouldn't it be more appropriate for the test apps to be in the tests directory rather than samples?

AenBleidd · 2023-10-06T06:24:43Z

'Tests' directory usually contains unit/integration/module tests.
And not really a test applications.
I'd personally keep them as-is in the samples folder.

CharlieFenton · 2023-10-06T06:40:40Z

@CharlieFenton, we have most of our samples built on the CI for MacOS.
Do we need to build sporadic sample all as well?

On the Mac we build the example_app (uppercase, uppercase graphics & slideshow), VBoxWrapper, wrapper, OpenCLApp, and the zip apps, all of which are samples or for direct use by projects. SInce it is a test app, I don't think this is in the same category.

I don't understand how samples/sporadic is to be used, if it is needed on more than one platform or even if it is needed on a regular basis after the sporadic apps functionality has been debugged.

I really don't want to spend time getting it to build on the Mac unless there is a compelling reason to do so.

davidpanderson · 2023-10-06T08:36:42Z

We won't need it on the Mac. Linux and Win is enough to debug API stuff.

AenBleidd · 2023-10-06T08:43:29Z

if it is needed on a regular basis after the sporadic apps functionality has been debugged.

I believe, it's always good to have the code available somewhere in case you need later require to test some additional functionality or to debug existing one because of some issue or corner case found.

Then I'll proceed with this PR and merge it since it's done.

AenBleidd · 2023-10-06T08:44:00Z

@davidpanderson, @CharlieFenton, thank you for working on this important topic!

davidpanderson added 8 commits September 21, 2023 10:00

Plumbing for sporadic app feature. Not finished.

290145d

add file

41e439a

fix compile warning

0536717

update VS project file

c5226bc

add debugging code

b7eee0c

debugging code

20fe4ab

AenBleidd requested review from AenBleidd and CharlieFenton October 3, 2023 21:28

AenBleidd added C: Client - Daemon P: Major C: Library PR: Review required C: Apps - Samples T: Enhancement labels Oct 3, 2023

AenBleidd added this to the Client/Manager 7.26.0 milestone Oct 3, 2023

update Xcode project file

ad0d421

AenBleidd marked this pull request as draft October 4, 2023 11:19

CharlieFenton approved these changes Oct 4, 2023

View reviewed changes

davidpanderson added 3 commits October 4, 2023 17:04

remove space

227d0cb

Win: fix simulator build

97addef

Merge branch 'dpa_sporadic' of https://github.com/BOINC/boinc into dp…

7674a44

…a_sporadic

AenBleidd added 2 commits October 5, 2023 17:24

Merge remote-tracking branch 'upstream/master' into dpa_sporadic

0a954d8

Add sporadic sample application to the MSVC solution

f68798b

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

Add sporadic sample app to the linux and android CI pipelines

9f80b5c

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

Fix build with Android

52daa40

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

AenBleidd approved these changes Oct 6, 2023

View reviewed changes

AenBleidd marked this pull request as ready for review October 6, 2023 08:43

AenBleidd merged commit 71e5fd0 into master Oct 6, 2023
48 of 49 checks passed

AenBleidd deleted the dpa_sporadic branch October 6, 2023 08:44

AenBleidd added PR: Reviewed and removed PR: Review required labels Oct 6, 2023

AenBleidd mentioned this pull request Mar 6, 2024

NCI and non-NCI apps on same project #1988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client: add sporadic app feature #5385

Client: add sporadic app feature #5385

davidpanderson commented Oct 3, 2023

AenBleidd commented Oct 4, 2023

CharlieFenton left a comment

davidpanderson commented Oct 4, 2023 via email

codecov bot commented Oct 5, 2023 •

edited

Loading

AenBleidd commented Oct 5, 2023

CharlieFenton commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023

davidpanderson commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023 •

edited

Loading

davidpanderson commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

Client: add sporadic app feature #5385

Client: add sporadic app feature #5385

Conversation

davidpanderson commented Oct 3, 2023

AenBleidd commented Oct 4, 2023

CharlieFenton left a comment

Choose a reason for hiding this comment

davidpanderson commented Oct 4, 2023 via email

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

AenBleidd commented Oct 5, 2023

CharlieFenton commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023

davidpanderson commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

CharlieFenton commented Oct 6, 2023 • edited Loading

davidpanderson commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

AenBleidd commented Oct 6, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

CharlieFenton commented Oct 6, 2023 •

edited

Loading