-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make wrappers work with sporadic apps #5410
Conversation
sporadic state via files. This allows, for example, sporadic VM apps. The logic for reading and writing of files is in the API library, rather than in the wrappers. Also: wrappers show message and exit if bad command line option. Also: small code shuffle in vboxwrapper to parse cmdline before doing anything.
API: debug sporadic stuff. Remove 2-second exit delay in standalone mode. client: if <heartbeat_debug>, show the heartbeat message don't create slot dir for --app_test job (it uses slots/app_test) don't show sporadic resoures used if there are none sporadic: add --wrapped option: don't use BOINC api; communicate via files wrapper: don't print start msg twice
@@ -63,9 +63,11 @@ void CLIENT_STATE::app_test_init() { | |||
// can put other stuff here like | |||
av->avg_ncpus = 1; | |||
av->flops = 1e9; | |||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this changed by intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@davidpanderson, build failed for OSX, please fix:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5410 +/- ##
============================================
- Coverage 10.85% 10.84% -0.02%
Complexity 1068 1068
============================================
Files 279 279
Lines 36114 36157 +43
Branches 8344 8355 +11
============================================
Hits 3920 3920
- Misses 31800 31843 +43
Partials 394 394
|
Add --sporadic option to wrapper and vboxwrapper.
When used, the wrapper communicates sporadic state with the app via files.
This allows, for example, sporadic apps that run in VMs.
The logic for reading/writing these files is in the BOINC runtime library;
to enable it, the wrapper calls boinc_sporadic_dir().
So changes to the wrappers is minimal.