Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: fix some PHP8 warnings #5470

Merged
merged 1 commit into from
Dec 22, 2023
Merged

web: fix some PHP8 warnings #5470

merged 1 commit into from
Dec 22, 2023

Conversation

davidpanderson
Copy link
Contributor

  • don't pass null to trim() or is_numeric()
  • gmdate() expects an integer; truncate
  • server status page: if app has no results, SQL aggregate functions return null; handle this.

Fixes #5467

@davidpanderson
web: fix some PHP8 warnings
2b0c173 
- don't pass null to trim() or is_numeric()
- gmdate() expects an integer; truncate
- server status page: if app has no results,
    SQL aggregate functions return null; handle this.
@AenBleidd AenBleidd self-assigned this Dec 22, 2023
@AenBleidd AenBleidd added this to the Server Release 1.6.0 milestone Dec 22, 2023
@AenBleidd AenBleidd merged commit ab7fefa into master Dec 22, 2023
75 of 81 checks passed
@AenBleidd AenBleidd deleted the dpa_php8_2 branch December 22, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees

@AenBleidd AenBleidd

Labels
C: Web - Project P: Minor PR: Bugfix
Projects
Server
Status: Done
Milestone
Server Release 1.6.0
Development

Successfully merging this pull request may close these issues.

More PHP 8 deprecation warnings
2 participants
@davidpanderson @AenBleidd