changes to support job-processing cookbook #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- script_assimilator: add batch_id option - add/fix comments - demo_submit_batch, sample_assimilate.py: finish -
script_assimilator:
in error case, pass WU name, ID, and batch ID
if verbose, show script cmdline
sample_assimilate.py:
write to ../sample_results/x
use batch ID in error case
show cmdlines if os.system() fails
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5490 +/- ##
============================================
- Coverage 10.84% 10.84% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 36158 36160 +2
Branches 8356 8357 +1
============================================
Hits 3920 3920
- Misses 31844 31846 +2
Partials 394 394
|
AenBleidd
requested changes
Jan 17, 2024
tools/sample_assimilate.py
Outdated
| if sys.argv[1] == '--error': | ||
| error_code = sys.argv[2] | ||
| wu_name = sys.argv[3] | ||
| wu_id = sys.argv[3] |
There was a problem hiding this comment.
@davidpanderson, here's a typo, I suppose it should be sys.argv[4]
There was a problem hiding this comment.
Oops!!! Thanks, fixed.
AenBleidd
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Python tools for submitting batches of jobs (sample_submit_batch)
and for assimilating jobs from these batches (sample_assimilate.py).
Extend script_assimilator to supply the data needed by the latter.