-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to support job-processing cookbook #5490
Conversation
- script_assimilator: add batch_id option - add/fix comments - demo_submit_batch, sample_assimilate.py: finish -
script_assimilator: in error case, pass WU name, ID, and batch ID if verbose, show script cmdline sample_assimilate.py: write to ../sample_results/x use batch ID in error case show cmdlines if os.system() fails
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5490 +/- ##
============================================
- Coverage 10.84% 10.84% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 36158 36160 +2
Branches 8356 8357 +1
============================================
Hits 3920 3920
- Misses 31844 31846 +2
Partials 394 394
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix one critical typo
tools/sample_assimilate.py
Outdated
if sys.argv[1] == '--error': | ||
error_code = sys.argv[2] | ||
wu_name = sys.argv[3] | ||
wu_id = sys.argv[3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidpanderson, here's a typo, I suppose it should be sys.argv[4]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops!!! Thanks, fixed.
Add Python tools for submitting batches of jobs (sample_submit_batch)
and for assimilating jobs from these batches (sample_assimilate.py).
Extend script_assimilator to supply the data needed by the latter.