Web: sanitize user URLs to prevent XSS attacks #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function sanitize_user_url() to do this. It accepts things like google.com http://google.com https://google.com?blah=foo&x=y but nothing else. There doesn't seem to be a PHP function that works, and stack overflow didn't yield anything plausible. When showing a user page, show 'Invalid URL' if it's nonempty and doesn't pass this. When a user edits their info, show error page if they enter an invalid URL.
|
@nilsjh, could you please check that this PR fixes the issues? |
AenBleidd
approved these changes
Jan 19, 2024
|
Thanks! When applied to our dev project, I get "Invalid URL" when trying both the XSS POF and other invalid URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function sanitize_user_url() to do this.
It accepts things like
google.com
http://google.com
https://google.com?blah=foo&x=y
but nothing else.
There doesn't seem to be a PHP function that works, and stack overflow didn't yield anything plausible.
When showing a user page,
show 'Invalid URL' if it's nonempty and doesn't pass this.
When a user edits their info, show error page if they enter an invalid URL.
Fixes #5491