Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler/client: add notion of 'strict memory bound' projects #5669

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

davidpanderson
Copy link
Contributor

I recently changed the client so that its estimate of a job's WSS is at least wu.rsc_memory_bound.
This addressed a problem with CPDN apps,
which have small WSS for a while and then get big; the client would run too many of these at once
and when they get big the system would run out of RAM and/or swap.

However, some projects have rsc_memory_bound quite a bit larger than actual WSS,
and this change caused the client to run fewer of these jobs, causing idle CPUs in some cases.

Solution: have a per-project 'strict memory bound' flag, specified in config.xml.
For projects that set this (like CPDN) we'll estimate WSS the new way; otherwise we'll use the old way.

I recently changed the client so that its estimate of a job's WSS
is at least wu.rsc_memory_bound.
This addressed a problem with CPDN apps,
which have small WSS for a while and then get big;
the client would run too many of these at once
and when they get big the system would run out of RAM and/or swap.

However, some projects have rsc_memory_bound quite a bit larger
than actual WSS,
and this change caused the client to run fewer of these jobs,
causing idle CPUs in some cases.

Solution: have a per-project 'strict memory bound' flag,
specified in config.xml.
For projects that set this (like CPDN) we'll estimate WSS the new way;
otherwise we'll use the old way.
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 10.53%. Comparing base (c807354) to head (ceb5113).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5669      +/-   ##
============================================
- Coverage     10.53%   10.53%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           279      279              
  Lines         35868    35871       +3     
  Branches       8409     8411       +2     
============================================
  Hits           3780     3780              
- Misses        31694    31697       +3     
  Partials        394      394              
Files Coverage Δ
sched/sched_config.cpp 0.00% <0.00%> (ø)
sched/sched_types.cpp 0.00% <0.00%> (ø)

@AenBleidd AenBleidd added this to the Client/Manager 8.0.4 milestone Jun 28, 2024
@AenBleidd AenBleidd merged commit 53f624d into master Jun 28, 2024
145 of 146 checks passed
@AenBleidd AenBleidd deleted the dpa_wss_strict branch June 28, 2024 10:00
AenBleidd added a commit to AenBleidd/boinc that referenced this pull request Jul 22, 2024
scheduler/client: add notion of 'strict memory bound' projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment