Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not keep explicit data on seal close method in DBC anchor #105

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

dr-orlovsky
Copy link
Member

The anchor contains an explicit DBC proof, which commits to the seal closing method by its type.

This PR also relaxes 1-to-1 match between DBC data type and closing method: before a DBC type was usable only for a single close method (since it dbc::Proof had a METHOD as a const). Now, enumeration DBC types, with different closing methods for each of the variants are supported. This API change was required for fixing a bug downstream in RGB crates prevending from using operations involving multiple seal seals with different closing methods simultaneously.

@dr-orlovsky dr-orlovsky added enhancement New feature or request *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) labels Oct 13, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 13, 2024
@dr-orlovsky dr-orlovsky self-assigned this Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.2%. Comparing base (f2bbab6) to head (ec9b612).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
dbc/src/anchor.rs 0.0% 4 Missing ⚠️
dbc/src/opret/mod.rs 0.0% 1 Missing ⚠️
dbc/src/tapret/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #105   +/-   ##
======================================
  Coverage    42.2%   42.2%           
======================================
  Files          35      35           
  Lines        3514    3511    -3     
======================================
  Hits         1483    1483           
+ Misses       2031    2028    -3     
Flag Coverage Δ
rust 42.2% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit ea80561 into master Oct 31, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus enhancement New feature or request *security* Issues affecting safety/security (include undefined behaviours)
Projects
Development

Successfully merging this pull request may close these issues.

1 participant