Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc #99

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Fix doc #99

merged 3 commits into from
Dec 29, 2021

Conversation

178vit
Copy link
Contributor

@178vit 178vit commented Dec 3, 2021

fix doc

mode Parameter is ‘train’, or ‘test’ not 'val' According to paddlepaddle's API Cifar10 and Cifar100 datasets.
@cjh3020889729
Copy link
Collaborator

Thanks for your Pull Request!

But I do have a few tips—— Can you rewrite it into the following format?

Now your code style:

else:
            mode = 'test'
            dataset = datasets.Cifar100(mode=mode, transform=get_val_transforms(config))

But there is a better form:

else:
            dataset = datasets.Cifar100(mode='test', transform=get_val_transforms(config))

Thank you again.

@xperzy
Copy link
Collaborator

xperzy commented Dec 29, 2021

LGTM

@xperzy xperzy merged commit b32948e into BR-IDL:develop Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants