Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinygltf.dist #19

Closed
wants to merge 1 commit into from
Closed

Update tinygltf.dist #19

wants to merge 1 commit into from

Conversation

redcarrera
Copy link
Contributor

Removed leading space from file name on line 27
Produces error with CMake v3.20.2

Removed leading space from file name on line 27
Produces error with CMake v3.20.2
@brlcad
Copy link
Member

brlcad commented Mar 28, 2022

@redcarrera That file actually has a space as the first character. Removing the space makes distcheck fail for me as that file then becomes unaccounted for. It's not erroring for me. Can you post what the error you're seeing in cmake is for it?

@redcarrera
Copy link
Contributor Author

@redcarrera That file actually has a space as the first character. Removing the space makes distcheck fail for me as that file then becomes unaccounted for. It's not erroring for me. Can you post what the error you're seeing in cmake is for it?

Yes, I'll grab the CMake error and provide the exact wording...

@redcarrera
Copy link
Contributor Author

@redcarrera That file actually has a space as the first character. Removing the space makes distcheck fail for me as that file then becomes unaccounted for. It's not erroring for me. Can you post what the error you're seeing in cmake is for it?

Here's the nastygram:

-- Adding src/conv/gltf...
CMake Error at misc/CMake/BRLCAD_Util.cmake:104 (_message):
Attempting to ignore non-existent file tinygltf/models/CubeImageUriSpaces/
2x2 image has multiple spaces.png, in directory
"C:/Workspace/BRL-CAD/Source/src/conv/gltf"

Result: Configuring incomplete, errors occurred!

I have attached a condensed version of the console log:

BRL-CAD_CMake_Condensed_Console_Log_20220328.txt

@redcarrera redcarrera closed this Apr 4, 2022
@redcarrera redcarrera deleted the redcarrera_tinygltf.dist branch April 4, 2022 10:07
zhuodannychen pushed a commit to zhuodannychen/brlcad that referenced this pull request May 9, 2023
Added more commands to InformationGatherer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants