Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Red Hand Destroyers "Collective" Weapons #3067

Closed
wants to merge 1 commit into from
Closed

Conversation

The4D6
Copy link
Collaborator

@The4D6 The4D6 commented Jan 8, 2024

Red Hand Destroyers now have their 1-in-5 weapons split in to two model selections (hammer or rad missile launcher).

I could not find for the life of me where collective was ticked (if it was) for these guys, so splitting in to two made more sense.

They dynamically adjust their max value in the unit based on the unit size but also based on how many of the other 1-in-5 selection there are.

This one requires feedback.

@The4D6 The4D6 self-assigned this Jan 8, 2024
@The4D6 The4D6 requested review from nstephenh and Mayegelt January 8, 2024 11:18
@The4D6 The4D6 linked an issue Jan 8, 2024 that may be closed by this pull request
@nstephenh
Copy link
Contributor

This looks like a Battlescribe only bug, I wonder if anything else is affected in the same way. It would theoretically be anything with a SEG (not SEG link) in a model that can have multiple options.

The other solution I could think of would be to move the SEG out of the unit and make it a link. Or don't fix it, and tell people to use NR instead.

@nstephenh
Copy link
Contributor

Ok, so after talking more to other devs and fully understanding the issue, the issue is that collective is set on the linked thunder hammer and the linked missile launcher, so they all try and take the same option. So there are two paths we can go down here:

  1. Link them to non-collective entries (make the missile launcher non-collective)
  2. Split them into two collective options.

I think 2. works better from a collection standpoint EXCEPT they can also upgrade their chainswords to a melee weapon. So, I think you need to do 3 options

  • Missile launcher and chain sword (1 in 5)
  • Thunder hammer and chain sword (1 in 5)
  • Heavy weapon and sword selection (1 in 5)

The 3rd option will certainly be taken the least, but it's the only way to get the "collective" unit we want.

Copy link
Contributor

@nstephenh nstephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See non-review comment.

@@ -3255,19 +3255,24 @@
<cost name="Pts" typeId="d2ee-04cb-5f8a-2642" value="15"/>
</costs>
</selectionEntry>
<selectionEntry id="34ff-115f-b2ad-9c40" name="Ravager w/ Heavy Weapon (1 in every 5)" hidden="false" collective="false" import="true" type="model">
<selectionEntry id="34ff-115f-b2ad-9c40" name="Ravager w/ Rad Missile Launcher (1 in every 5)" hidden="false" collective="false" import="true" type="model">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these guys melee choice isn't collective they don't group as collective. Also, their "two blades" option is collective so that causes some weirdness.

Finally, should we regen the ID on the heavy weapon guy that turned into rad missile launcher so someone who had a list with these before doesn't find their thunder hammers all turned into missile launchers?

@The4D6 The4D6 closed this Jan 10, 2024
@The4D6 The4D6 deleted the 4d6/red-hand-fix branch January 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World Eaters Red Hands Destroyers
2 participants