Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vigil Stormshields on Command Squads and Sabre Pintle Weapons #3157

Merged

Conversation

Mayegelt
Copy link
Contributor

@Mayegelt Mayegelt commented Mar 28, 2024

Vigil Stormshields on Termy Command Squads. Added additional lines to allow termy command squads to take vigil shields when they are a retinue for a termy praetor. #3153

Sabre Pintle Weapons changed from Collective to none collective versions. #3149

This for some reason is showing as having over 50,000 changes, I'm not sure why. See pull request "Retest" for example. #3156

Tested on BS as working. Don't know for NR.

Vigil Stormshields on Termy Command Squads. Added additional lines to allow termy command squads to take vigil shields when they are a retinue for a termy praetor.

Sabre Pintle Weapons changed from Collective to none collective versions.

This for some reason is showing as having over 50,000 changes, I'm not sure why. See pull request "Retest" for example. #3156
@Mayegelt Mayegelt requested review from nstephenh and The4D6 March 28, 2024 09:22
@Mayegelt
Copy link
Contributor Author

Spoken with Madspy on the BS Discord and he has confirmed it is just an NR change that has changed the way linebreaks work.
image
image
image

Actual changes here.

@Mayegelt
Copy link
Contributor Author

Side note...
This will mean that the next changes to all files will have this same issue of throwing up that everything has changed. So it might be worth just rolling every catalogue forward 1 number then saving and uploading the new version.
Hopefully then everything else will not flag all the errors in future pull requests.

@nstephenh nstephenh merged commit 9b3b42f into main Mar 28, 2024
2 checks passed
@nstephenh nstephenh deleted the Vigil-Stormshields-on-Command-Squads-and-Sabre-Pintle-Weapons branch March 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants