-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable C++11 in cmake #5325
base: master
Are you sure you want to change the base?
Enable C++11 in cmake #5325
Conversation
I agree that c++11 should be enabled, however it is also included in #5294 because it was necessary for move semantics and other c++11 features. Be aware that this PR also includes enabling c++11 but in a slightly different manner. It bumps required cmake version to 3.1, since this works on Ubuntu 14.04 I don't see an issue there. |
Note that #5294 doesn't bump the required version for CUDA to 7.0 and doesn't enable C++11 for It does seem that just dropping the old build system would save everyone a lot of trouble. But I suppose that is a different discussion. |
This commit resolves my issue of adding C++11 dependent layers. Hopefully it will be merged into master soon so that people won't return into the same issue. |
@de-vri-es Is there any particular benefit to not, by default, enabling "C++11 for |
The main reason would be to support CUDA < 7.0. There doesn't seem to be a pressing need to enable C++11 support in CUDA code right now. However, I'm not against bumping the minimum CUDA version and enabling C++11. Though the cmake 3.1 path should also have this then:
|
|
This PR enables C++11 for compilation of both C++ and CUDA code (see #5262).
As C++11 has been supported by CUDA since 7.0, the minimally required version is bumped as well in the cmake file. In order to not raise warnings, host compiler flag propagation to nvcc is disabled (see https://cmake.org/Bug/view.php?id=15240).