Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/node23 v8 api deprecations #916

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

tomcatliu2016
Copy link

No description provided.

@BYVoid
Copy link
Owner

BYVoid commented Nov 4, 2024

thanks but why does it require C++20?

@tomcatliu2016
Copy link
Author

When building with Nodejs 23 on the latest MacOS, it gives the errors
2024-11-02T08:42:39.7556350Z /Users/runner/Library/Caches/node-gyp/23.1.0/include/node/v8config.h:13:2: error: "C++20 or later required.
It is ok to change to C++20 for MacOS only, but I change both to maintain consistent compatibility for MacOS and Linux.
It seems that C++20 is also OK for Linux.
image

@BYVoid BYVoid merged commit 71cb906 into BYVoid:master Nov 5, 2024
25 checks passed
NorthernMan54 added a commit to homebridge/node-pty-prebuilt-multiarch that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants