Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a lot of typos #362

Open
wants to merge 8 commits into
base: 2.4
Choose a base branch
from
Open

Fix a lot of typos #362

wants to merge 8 commits into from

Conversation

TheGiraffe3
Copy link
Contributor

Detected using automated processes.

@TheGiraffe3 TheGiraffe3 mentioned this pull request Sep 23, 2024
Closed
@TheGiraffe3 TheGiraffe3 marked this pull request as ready for review September 23, 2024 16:09
@TheGiraffe3
Copy link
Contributor Author

@blast007 could I get a review please?

RighthandSon
RighthandSon suggested changes Oct 22, 2024
View reviewed changes
Copy link

@RighthandSon RighthandSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't many devs and things tend to take awhile here, especially on a big PR with lots of changes like this one.
Most changes look pretty good, the two that I have questions about are:
UnSilence vs Unsilence Is this really a needed change, given the use case it seems fine to me as is.
The removal of misc/libtool.m4 while I haven't dug into where/why this is used, why is it lumped in with a bunch of spelling fixes?

AUTHORS Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
src/game/Intersect.cxx Outdated Show resolved Hide resolved
man/bzflag.6.in Outdated Show resolved Hide resolved
include/bzfsAPI.h Outdated Show resolved Hide resolved
include/bzfsAPI.h Outdated Show resolved Hide resolved
man/bzflag.6.in Outdated Show resolved Hide resolved
TheGiraffe3 and others added 5 commits October 22, 2024 18:23
@TheGiraffe3 @RighthandSon
Update AUTHORS
1ccfc20 
Co-authored-by: RighthandSon <59427094+RighthandSon@users.noreply.github.com>
@TheGiraffe3 @RighthandSon
Apply suggestions from code review
8b021b6 
Co-authored-by: RighthandSon <59427094+RighthandSon@users.noreply.github.com>
@TheGiraffe3 @RighthandSon
Update man/bzflag.6.in
d35633a 
Co-authored-by: RighthandSon <59427094+RighthandSon@users.noreply.github.com>
@TheGiraffe3 @RighthandSon
Update include/bzfsAPI.h
4b2f0ed 
Co-authored-by: RighthandSon <59427094+RighthandSon@users.noreply.github.com>
@TheGiraffe3 @RighthandSon
Update include/bzfsAPI.h
b9e5675 
Co-authored-by: RighthandSon <59427094+RighthandSon@users.noreply.github.com>
@TheGiraffe3
Copy link
Contributor Author

The removal of misc/libtool.m4 while I haven't dug into where/why this is used, why is it lumped in with a bunch of spelling fixes?

See the original PR.

Sorry about the computting thing... I guess I need to not assume that replacing "puting" with "putting" won't change anything else.

@RighthandSon
Copy link

Ahh, my bad for not looking at the original. 👍

@agatha2
Copy link

agatha2 commented Oct 22, 2024 •
edited
Loading

(Edit: comment obsolete because I was looking at the original.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RighthandSon RighthandSon RighthandSon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheGiraffe3 @RighthandSon @agatha2