Skip to content

Commit

Permalink
Stronger defense for Back compat (#15203)
Browse files Browse the repository at this point in the history
* Stronger defense for Back compat

* .
  • Loading branch information
deltakosh authored Jun 14, 2024
1 parent 7b2c834 commit 6937f31
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/dev/core/src/Materials/Node/nodeMaterial.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2469,6 +2469,9 @@ export class NodeMaterial extends PushMaterial {
nodeMaterial.parseSerializedObject(serializationObject, undefined, undefined, urlRewriter);
nodeMaterial.snippetId = snippetId;

// We reset sideOrientation to default value
nodeMaterial.sideOrientation = null;

try {
if (!skipBuild) {
nodeMaterial.build();
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Meshes/abstractMesh.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class _InternalAbstractMeshDataInfo {
* Bounding info that is unnafected by the addition of thin instances
*/
public _rawBoundingInfo: Nullable<BoundingInfo> = null;
/**
/** @internal
* This value will indicate us that at some point, the mesh was specifically used with the opposite winding order
* We use that as a clue to force the material to sideOrientation = null
*/
Expand Down

0 comments on commit 6937f31

Please sign in to comment.