Merge pull request #9777 from kaliatech/fix-chrome-passive-evt-warning

Fix passive event warning in chrome
BabylonJS · Jan 12, 2021 · 6976462 · 6976462
2 parents d163b86 + 9ac4245
commit 6976462
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/dist/preview release/what's new.md b/dist/preview release/what's new.md
@@ -104,6 +104,7 @@
 - Fix SSAO2 with PrePass sometimes causing colors brighter than they should be ([CraigFeldspar](https://github.com/CraigFeldspar))
 - Fix PostProcess sharing between cameras/renderTargets, that would create/destroy a texture on every frame ([CraigFeldspar](https://github.com/CraigFeldspar))
 - Fix for DualSense gamepads being incorrectly read as DualShock gamepads ([PolygonalSun](https://github.com/PolygonalSun))
+- Fix for warning in chrome about passive wheel events ([#9777](https://github.com/BabylonJS/Babylon.js/pull/9777)) ([kaliatech](https://github.com/kaliatech))
 - Fix crash when cloning material in `AssetContainer.instantiateModelsToScene` when mesh is an instanced mesh ([Popov72](https://github.com/Popov72))
 
 ## Breaking changes

diff --git a/src/Inputs/scene.inputManager.ts b/src/Inputs/scene.inputManager.ts
@@ -848,7 +848,28 @@ export class InputManager {
                     ? "mousewheel" // Webkit and IE support at least "mousewheel"
                     : "DOMMouseScroll"; // let's assume that remaining browsers are older Firefox
 
-            elementToAttachTo.addEventListener(this._wheelEventName, <any>this._onPointerMove, false);
+            // Chrome reports warning in console if wheel listener doesn't set an explicit passive option.
+            // IE11 only supports captureEvent:boolean, not options:object, and it defaults to false.
+            // Feature detection technique copied from: https://github.com/github/eventlistener-polyfill (MIT license)
+            // ----------
+            var passiveSupported = false;
+            var noop = function () {};
+            try {
+                var options: object = {
+                        passive: {
+                            get: function () {
+                                passiveSupported = true;
+                            }
+                        }
+                    };
+                elementToAttachTo.addEventListener("test", noop, options);
+                elementToAttachTo.removeEventListener("test", noop, options);
+            } catch (e) {
+                /* */
+            }
+            // ----------
+
+            elementToAttachTo.addEventListener(this._wheelEventName, <any>this._onPointerMove, passiveSupported ? { passive: false } : false);
         }
 
         if (attachDown) {