Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute dispatch indirect API #14970

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 10, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@stefnotch
Copy link
Contributor Author

Ok, how do I label this PR?

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 10, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from Popov72 April 10, 2024 19:14
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@stefnotch
Copy link
Contributor Author

@Popov72 Thanks for the excellent feedback. I should have implemented it, which makes this PR ready.

I can, of course, wait until #14931 is merged, and then recreate this PR.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14970/merge/testResults/webgpuplaywright/index.html

@sebavan
Copy link
Member

sebavan commented Apr 12, 2024

#14931 will be merged on Monday

@stefnotch
Copy link
Contributor Author

Oh sweet, there weren't even any merge conflicts. This should be ready for merging (as soon as the pipeline is green).

@sebavan sebavan merged commit 3fdd140 into BabylonJS:master Apr 16, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants