Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger defense for Back compat #15203

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Stronger defense for Back compat #15203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df92fee
Stronger defense for Back compat
deltakosh Jun 14, 2024
0a8b01f
.
deltakosh Jun 14, 2024
7e34810
.
deltakosh Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/dev/core/src/Materials/Node/nodeMaterial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2469,6 +2469,9 @@ export class NodeMaterial extends PushMaterial {
nodeMaterial.parseSerializedObject(serializationObject, undefined, undefined, urlRewriter);
nodeMaterial.snippetId = snippetId;

// We reset sideOrientation to default value
nodeMaterial.sideOrientation = null;

try {
if (!skipBuild) {
nodeMaterial.build();
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Meshes/abstractMesh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class _InternalAbstractMeshDataInfo {
* Bounding info that is unnafected by the addition of thin instances
*/
public _rawBoundingInfo: Nullable<BoundingInfo> = null;
/**
/** @internal
* This value will indicate us that at some point, the mesh was specifically used with the opposite winding order
* We use that as a clue to force the material to sideOrientation = null
*/
Expand Down