Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh: Fix back compat for sideOrientation when parsing mesh #15206

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jun 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 15, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15206/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@Popov72
Copy link
Contributor Author

Popov72 commented Jun 15, 2024

The "NME Shadow Map" test fails in WebGL1 with a "Exceeded timeout of 40000 ms for a test." error, I don't really know why...

I already tried to restart the job, but with no luck.

@RaananW
Copy link
Member

RaananW commented Jun 16, 2024

@Popov72
Copy link
Contributor Author

Popov72 commented Jun 16, 2024

We don't support writing to gl_FragDepth in WebGL1, so I've removed the faulty test from the WebGL1 test suite.

@RaananW RaananW merged commit ebb22ff into BabylonJS:master Jun 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants