Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarations - const enum to enums #15235

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jun 27, 2024

When preserving const enums (to be available in js) the exported code is identical to a standard export ofr an enum. However, typescript still fails compilation when trying to iterate over it though it will work correctly when used directly in js.

This reverts const enums to enums in our UMD declarations, which will allow any playground using enum iteration in typescript to work.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 27, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 27, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 27, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 27, 2024

@RaananW RaananW enabled auto-merge (squash) June 27, 2024 12:54
@RaananW RaananW merged commit fe4df00 into BabylonJS:master Jun 27, 2024
12 checks passed
@RaananW RaananW deleted the constEnumToEnum branch June 27, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants