Add first draft documenting OpenPBR support in Babylon.js #1272
Conversation
|
snapshot for this PR available at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1272/merge |
|
snapshot for this PR available at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1272/merge |
|
cc @RaananW if you have a clue regarding https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1272/merge/features/featuresDeepDive/materials/using/OpenPBR/ ? |
Done at 4c5a96e. The layout looks correct to me now. |
|
snapshot for this PR available at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1272/merge |
|
Looks all good for me as well now 🤷 |
There was a problem hiding this comment.
Some general questions about FIXME in the doc. If we aren't done with the doc, maybe we should hold off on the initial PR so the page doesn't feel like it was pushed up incomplete. If these are not implemented, we should change the term so it is clear that the implementation is not done yet and the FIXME doesn't apply to the documentation.
|
|
||
| | Parameter | Support in Babylon.js | | ||
| | ------------------------ | --------------------- | | ||
| | `base_weight` | Newly implemented | |
There was a problem hiding this comment.
should we expand this description to give an indication of what it is? Something like "newly implemented scalar value that multiplies against albedo color"? Seems like it would be good to not send people out of our docs to track down what Open PBR parameters mean.
There was a problem hiding this comment.
We'll definitely want the documentation to stand on its own, but I'm not quite there yet. We'll also have to find a balance so as not to repeat (and risk getting out of sync with) what's already described in the OpenPBR official documentation.
|
snapshot for this PR available at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1272/merge |
|
looks like it is ready to go ? can I move out of draft ? |
|
I looked it over again with the latest changes and it looks good to me. |
This PR adds to the documentation a page about OpenPBR, serving 3 purposes: