Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EPS & SVG Rendering usable on international locales #177

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bardiir
Copy link

@bardiir bardiir commented Mar 23, 2024

Revisit pr#84 as pr#100 did not address nearly all instances of the rounding error. Amended the pull request with the solution presented in pr#100 adapted to all functions

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 66.51%. Comparing base (b0105c7) to head (45082c4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Renderer/Image/EpsImageBackEnd.php 0.00% 13 Missing ⚠️
src/Renderer/Image/SvgImageBackEnd.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #177   +/-   ##
=========================================
  Coverage     66.51%   66.51%           
  Complexity      993      993           
=========================================
  Files            49       49           
  Lines          3178     3178           
=========================================
  Hits           2114     2114           
  Misses         1064     1064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DASPRiD
Copy link
Member

DASPRiD commented Apr 18, 2024

Can you have a look at the failing checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants