Added a new validator ‘exclusiveMaximum’, closes #10

Baggz · Nov 29, 2011 · 189f421 · 189f421
1 parent ad5b9fc
commit 189f421
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/amanda.js b/src/amanda.js
@@ -640,7 +640,12 @@
      * Maximum
      */
     'maximum': function(property, propertyValue, validator, propertyValidators, callback) {
-      return (typeof propertyValue !== 'number' || propertyValue > validator) ? callback(true) : callback();
+      if (typeof propertyValue === 'number') {
+        var condition = (propertyValidators.exclusiveMinimum) ? propertyValue <= validator : propertyValue < validator;
+        return (condition) ? callback() : callback(true);
+      } else {
+        return callback(true);
+      }
     },
 
     /**

diff --git a/tests/validators/maximum.js b/tests/validators/maximum.js
@@ -15,13 +15,14 @@ exports['Test #1'] = function(test) {
   };
 
   [
+    10,
     11,
     100,
     {},
     null,
     [],
     function() {},
-    'Hello!' 
+    'Hello!'
   ].forEach(function(input) {
     amanda.validate(input, schema, function(error) {
       count += 1;
@@ -34,11 +35,6 @@ exports['Test #1'] = function(test) {
     test.equal(error, undefined);
   });
 
-  amanda.validate(10, schema, function(error) {
-    count += 1;
-    test.equal(error, undefined);
-  });
-
   test.equal(count, 9);
   test.done();