-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAH-1236 | Bug fix. Modified query to display only preferred patients… #110
base: master
Are you sure you want to change the base?
Conversation
Why DELETE and INSERT? And not instead just UPDATE? |
Ohh we thought we have to update the whole table. Okay we will just update that file and push them again. |
@gsluthra we have modified the file with the update statement. |
Just for reference, these are the older SQL queries that were there before this change was made:
|
Different Tabs tested in this flow are:
Note:
Scenario's Tested after merging 2 or 3 patients:
|
Thanks! sounds good. |
where v.date_stopped is null AND v.voided = 0;" | ||
WHERE property = "emrapi.sqlSearch.activePatients"; | ||
|
||
UPDATE global_property SET property_value = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please break the SQL file into 3 different ones please and also create liquibase changesets that are specific to a specific property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sure.
@@ -3874,6 +3874,11 @@ | |||
<sqlFile path="V1_98_WardsListSql.sql"/> | |||
</changeSet> | |||
|
|||
<changeSet id="bahmni-PatientSearch-Update-202201250315" author="Kavitha S, Soorya Kumaran C"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please use 3 different changesets as suggested above? also please make sure that the changeset clearly says which is for which property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
… in active tab after merging Co-authored-by: Kavitha S <kavitha.s@thoughtworks.com>
Co-authored-by: Kavitha S <kavitha.s@thoughtworks.com>
Co-authored-by: Soorya Kumaran C <sooryakumaran.c@thoughtworks.com>
12edb7d
to
162bd9f
Compare
… in active tab after merging
Co-authored-by: Kavitha S kavitha.s@thoughtworks.com