BahmniPatientProfileResourceTest#updatePatient() fails when actually adding relationships

[Andu033]

No description provided.

[Andu033]

@rbuisson

[Andu033]

Update patient test fail just by adding a relationship in patient.json. The reason for failing is that PatientResource1_8 is null. Doesnt return that return from context.

[rbuisson]

Remove this as well.

[mks-d]

@Andu033 @rbuisson isn't there a ticket linked to this PR?

[mks-d]

@Andu033 you will have to add something that returns a mock for PersonResource1_8 like it is done here for PatientResource1_8, something like that:

PowerMockito.when(restService.getResourceBySupportedClass(Person.class))
  .thenReturn(personResource1_8);

... and make sure that the mock does what it should for the tests to make sense.

Cc @rbuisson

[rbuisson]

Not straighftoward to make this work. In fact the tests weren't testing anything.
I have also renamed some of the variables to make it clearer.

This is now fixed but I am still unsure why the BahmniPatientProfileResource#update method is calling twice the patientProfile.setRelationships().

bahmni-core/bahmnicore-omod/src/main/java/org/bahmni/module/bahmnicore/web/v1_0/controller/BahmniPatientProfileResource.java

Line 164 in 84a9aa6

delegate.setRelationships(getRelationships(propertiesToUpdate, delegate.getPatient()));

https://github.com/Bahmni/bahmni-core/blob/master/bahmnicore-omod/src/main/java/org/bahmni/module/bahmnicore/web/v1_0/controller/BahmniPatientProfileResource.java#L185