Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in advice definition #26

Open
deniger opened this issue Feb 28, 2020 · 1 comment
Open

Typo in advice definition #26

deniger opened this issue Feb 28, 2020 · 1 comment

Comments

@deniger
Copy link

deniger commented Feb 28, 2020

At module startup, the following error is produced:
WARN - ModuleFactory.loadAdvice(894) |2020-02-28 07:47:24,479| Could not load advice point: org.openmrs.module.appointments.service.AppointmentServiceService

This advice is defined in omod module, the file src/main/resources/config.xml ( line 47):
<point>org.openmrs.module.appointments.service.AppointmentServiceService</point>

Should be replaced by:
<point>org.openmrs.module.appointments.service.AppointmentService</point>

deniger added a commit to deniger/openmrs-module-appointments that referenced this issue Feb 28, 2020
See: Bahmni#26

Replace `AppointmentServiceService` by `AppointmentService`
@mddubey
Copy link
Member

mddubey commented Jun 17, 2020

Hello @deniger!
Thanks for raising this issue. There has been a mistake in the config.xml while renaming one of the services.
However the correct service it should point to is org.openmrs.module.appointments.service.AppointmentServiceDefinitionService instead of AppointmentService.

This AppointmentServiceService was renamed to AppointmentServiceDefinitionService as part of this commit but the changes in config.xml were missed.

Thanks
CC: @angshu @binduak @praveenadayanand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants