Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-82 - Timezone support for service definitions start and end times #73

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

icrc-psousa
Copy link
Contributor

Ticket: AP-82
Description: Reviewed services saving / loading to cope with timezones

  • Include Date and timezone info when converting Time to String so that, when it's consumed, it can be properly converted to other timezones. We'll need to add current date to the time and not something like "January 01, 1970" to have the right hour whether we are on daylight saving time or not.

@icrc-psousa icrc-psousa marked this pull request as ready for review January 26, 2022 11:45
@ibacher
Copy link
Contributor

ibacher commented Jan 31, 2022

@angshu @binduak Any chance this can be reviewed?

@icrc-psousa
Copy link
Contributor Author

@angshu @binduak PR was adapted to have DB times saved with server time instead of UTC as discussed. Would it be possible to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants