[Sowmya|Tanya] | Adds logic to fetch drug chart data | A-1204950368410820 #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjun-Go
approved these changes
Aug 18, 2023
|
Since you don't need the confirmBox in the patientDasboardController, the mocks for the confirmbox can be removed from the test file as well. - |
| onConfirm: PropTypes.func, | ||
| }), | ||
| patientId: PropTypes.string, | ||
| forDate: PropTypes.instanceOf(Date), |
There was a problem hiding this comment.
Do we need to send the forDate from Bahmni Apps?
I think the navigation of dates will be driven from IPD module only. So I think sending only patientId would be sufficient.
| }); | ||
| } | ||
| patientId: $stateParams.patientUuid, | ||
| forDate: new Date().toUTCString() |
There was a problem hiding this comment.
We are directly passing the epoch value of date from bahmniapps. In IPD-frontend repo we are directly receiving the epoch value for forDate
There was a problem hiding this comment.
Okay, for now lets keep it like this, We might have to revisit this when navigation card is played.
Phanindra-tw
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.