Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined JSON payloads 2024-W49 #1538

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Combined JSON payloads 2024-W49 #1538

merged 4 commits into from
Dec 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 2, 2024

Automated changes by create-pull-request GitHub action

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Dec 2, 2024 •
edited
Loading

FILENAME: BIPs/00batched/2024-W49/1-0xc38c5f97B34E175FFd35407fc91a937300E33860.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 2680a983f669df1ea255795ec1f1a044fb195a2e
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

Gauge Validator (0xB7Bb16B58b04fE4f8d270430cE57d2A4753993de) Result
validate_preferential_gauge ✅
validate_rate_providers_safety --
Gauge Validator (0xAf1b4bfA0a69B9e669d925888b99741E15e37253) Result
validate_preferential_gauge ✅
validate_rate_providers_safety -- 
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+--------------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| function              | pool_id_and_address                                                 | symbol_and_info | gauge_address_and_info                           | tokens                                                 | rate_providers                             | review_summary |   bip   | tx_index |
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+--------------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| GaugeAdderV4/addGauge | 0xdcb5ed405a9b11250def047ae8016008fae7d69b0000000000000000000006d8  | WETH-lpETH      | root: 0xB7Bb16B58b04fE4f8d270430cE57d2A4753993de | 0xa684EAf215ad323452e2B2bF6F817d4aa5C116ab: lpETH      | 0x0000000000000000000000000000000000000000 |       --       | BIP-735 |    0     |
|                       | pool_address: 0xdCb5ED405a9b11250deF047AE8016008Fae7D69b            | fee: 0.3        | side: None                                       | 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2: WETH       | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     | a-factor: 500   | style: mainnet                                   | 0xdCb5ED405a9b11250deF047AE8016008Fae7D69b: WETH-lpETH | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     |                 | cap: 100.0%                                      |                                                        |                                            |                |         |          |
|                       |                                                                     |                 | preferential: True                               |                                                        |                                            |                |         |          |
| GaugeAdderV4/addGauge | 0x8950e720eb51af9709a86941345844134517bcf40002000000000000000006e9  | ECLP-GHO-pyUSD  | root: 0xAf1b4bfA0a69B9e669d925888b99741E15e37253 | 0x40D16FC0246aD3160Ccc09B8D0D3A2cD28aE6C2f: GHO        | 0x0000000000000000000000000000000000000000 |       --       | BIP-736 |    1     |
|                       | pool_address: 0x8950E720eB51AF9709A86941345844134517bcF4            | fee: 0.01       | side: None                                       | 0x6c3ea9036406852006290770BEdFcAbA0e23A0e8: PYUSD      | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     | a-factor: N/A   | style: mainnet                                   |                                                        |                                            |                |         |          |
|                       |                                                                     |                 | cap: 100.0%                                      |                                                        |                                            |                |         |          |
|                       |                                                                     |                 | preferential: True                               |                                                        |                                            |                |         |          |
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+--------------------------------------------------------+--------------------------------------------+----------------+---------+----------+

FILENAME: BIPs/00batched/2024-W49/1-0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 2680a983f669df1ea255795ec1f1a044fb195a2e
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+----------+-------------------------------------------------+----------------------------------------------------------------------+----------------------------+---------+----------+
| function | token_symbol                                    | recipient                                                            | amount                     |   bip   | tx_index |
+----------+-------------------------------------------------+----------------------------------------------------------------------+----------------------------+---------+----------+
| transfer | USDC:0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48 | multisigs/foundation_opco:0x3B8910F378034FD6E103Df958863e5c684072693 | 60000.0 (RAW: 60000000000) | BIP-738 |    0     |
+----------+-------------------------------------------------+----------------------------------------------------------------------+----------------------------+---------+----------+

FILENAME: BIPs/00batched/2024-W49/1101-0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa.json
MULTISIG: multisigs/dao (zkevm:0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa)
COMMIT: 2680a983f669df1ea255795ec1f1a044fb195a2e
CHAIN(S): zkevm
TENDERLY: 🟪 SKIPPED (ValueError({'error': {'id': '5960f12d-f529-4771-956f-62b56607d13d', 'slug': 'invalid_transaction_simulation', 'message': 'Unsupported network'}}))

+----------------------+--------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function             | caller_name        | caller_address                             | fx_paths                                                                                                   | action_ids                                                         |   bip   | tx_index |
+----------------------+--------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRole | mimic/smartVaultV3 | 0x9e5D6427D2cdaDC68870197b099C2Df535Ec3c97 | 20220517-protocol-fee-withdrawer/ProtocolFeesWithdrawer/withdrawCollectedFees(address[],uint256[],address) | 0xcd3768eb08cdc2de2d040f74fb351ccbef01df1d042fa8033e12f224ecc27c4d | BIP-737 |    0     |
+----------------------+--------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

Tritium-VLK
Tritium-VLK previously approved these changes Dec 2, 2024
View reviewed changes
Xeonus
Xeonus approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined payloads as expected:

  • gauge adds
  • send 60k USDC to OpCo
  • enable mimic smart vault withdrawals on zkevm

@gosuto-inzasheru gosuto-inzasheru merged commit cecbe73 into main Dec 4, 2024
@gosuto-inzasheru gosuto-inzasheru deleted the gha-payload-merge-2024-W49 branch December 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeonus Xeonus Xeonus approved these changes

@Tritium-VLK Tritium-VLK Tritium-VLK left review comments

@mikebmikeb mikebmikeb Awaiting requested review from mikebmikeb

Assignees
No one assigned
Labels
Merged Payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xeonus @Tritium-VLK @gosuto-inzasheru