Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate BIP-431 CSV to multisig json #525

Merged
merged 17 commits into from
Oct 8, 2023
Merged

Translate BIP-431 CSV to multisig json #525

merged 17 commits into from
Oct 8, 2023

Conversation

Tritium-VLK
Copy link
Member

Somehow it's nto working as expected @SHAKOTN been staring at this too long, can you take a look, my guess ins it'll take you 30 seconds to see the problem.

I know you hate brownie.

Tritium added 3 commits September 22, 2023 18:05
Automated ARB payments.
2a0a530
Merge remote-tracking branch 'origin/main'
1278798 
# Conflicts:
#	BIPs/00arbIncentives/2023-W37-airdrop.json
script to make a json out of the csv, but it's broken.
9956d7c 
Asking shak to take a look.

Repeats the last number all the time but only in the list, not when iterating.
@Tritium-VLK Tritium-VLK requested a review from SHAKOTN September 25, 2023 20:46
@github-actions
Copy link
Contributor

File name: BIPs/00batched/2023-W38/BIP-431-airdrop.json
COMMIT: 052950fd8fee178cff61010b314484c6c4450d09
CHAIN(S): arbitrum

+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| function   | token_symbol                                    | recipient                                      | amount                        | bip     |   tx_index |
+============+=================================================+================================================+===============================+=========+============+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc59a1a2ed72Eb7B31b8eaEdAB1f6f8D8c8881365 | 3187.040443 (RAW: 3187040443) | BIP-431 |          0 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xd56e9F604ba364d5Df09730afcF946845ACe6683 | 2715.625111 (RAW: 2715625111) | BIP-431 |          1 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5C866C6ae5187130C234BC474A9fd55e3ea0Ac5D | 1744.260251 (RAW: 1744260251) | BIP-431 |          2 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xE356E05c77c4Df64FFd033432b969E229980F28b | 1578.0 (RAW: 1578000000)      | BIP-431 |          3 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5a407865411253E5A991d3e49E8Bc7A1FdBE82B0 | 1262.081183 (RAW: 1262081183) | BIP-431 |          4 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc407D9993b29F0aDA4a98686F134C78567D0F562 | 1200.0 (RAW: 1200000000)      | BIP-431 |          5 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xF7401728edd23290d8099eD73f155101dCf8CC0C | 1123.482439 (RAW: 1123482439) | BIP-431 |          6 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc4F91e9d571D1366551E01056a1C8a2B8b01F8Ec | 1012.546862 (RAW: 1012546862) | BIP-431 |          7 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x1a7c7F0C3deFe3818A0a8d90b41573546717f145 | 429.375872 (RAW: 429375872)   | BIP-431 |          8 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x8484e288b7C2Edad1b5214ed9Df3BaE4af7dadf5 | 147.906745 (RAW: 147906745)   | BIP-431 |          9 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x1928c92C7b9d9A9699776f9Fb57aD6C84b44bE33 | 108.30214 (RAW: 108302140)    | BIP-431 |         10 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5614c860bfcB8d8Ea59E14c8aeE0b3F73511Cd5B | 96.394942 (RAW: 96394942)     | BIP-431 |         11 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xe69e85B87E46Ff35B32bD93aa5E9cf0a09B1c221 | 86.010151 (RAW: 86010151)     | BIP-431 |         12 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xA24D30Dd8cEC57A8be66f7359c7CCed581Df29Ed | 71.99547 (RAW: 71995470)      | BIP-431 |         13 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xFf4F7b726eE86f810531d2842B3BDd8A512dB594 | 67.914668 (RAW: 67914668)     | BIP-431 |         14 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x83E92a956c551BEc407d83e17f4317d9771466c3 | 66.156207 (RAW: 66156207)     | BIP-431 |         15 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x82b417bA7dAf38C496435E23e7714B5860C1C85F | 64.244563 (RAW: 64244563)     | BIP-431 |         16 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x53Cfd45B8416322a72009BcF0F57f54d906D947b | 60.076408 (RAW: 60076408)     | BIP-431 |         17 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xBC0b4983f6375b25ae7d0f8f56d029Cc24f78D05 | 40.248605 (RAW: 40248605)     | BIP-431 |         18 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x73e47E110dD251bd6449381724F2BB51C11b14BC | 21.6671 (RAW: 21667100)       | BIP-431 |         19 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x4624C8BDe33545893BaC01a999DDa0F9296B3588 | 19.184894 (RAW: 19184894)     | BIP-431 |         20 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x3D631a345B1b45Bf8A1456e43F91267304d5E048 | 15.997492 (RAW: 15997492)     | BIP-431 |         21 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5388A7f24e86c9c9D855A98C2F5a339AFA6a3acc | 12.279972 (RAW: 12279972)     | BIP-431 |         22 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x892faC1BeB41e5E4B44A21E2DbE238D92FF9564c | 6.718158 (RAW: 6718158)       | BIP-431 |         23 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x6D7Ac63Aaa7bA8925dcB3E44BE6355261dCF688f | 5.7236 (RAW: 5723600)         | BIP-431 |         24 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xEE49B4204275D1439d38aF53dDaFfA940b07F111 | 3.150087 (RAW: 3150087)       | BIP-431 |         25 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x40b1d8B0B7232eb3258a455445ECfb3813f13fb8 | 3.119999 (RAW: 3119999)       | BIP-431 |         26 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x125aD150043F25A8C0A09C8b82Ac2a26EaAC1400 | 1.868476 (RAW: 1868476)       | BIP-431 |         27 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x75c9aA37a479d5EdF521A505D9b366B442c80Dac | 1.793849 (RAW: 1793849)       | BIP-431 |         28 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xdf330Ccb1d8fE97D176850BC127D0101cBe4e932 | 1.395061 (RAW: 1395061)       | BIP-431 |         29 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+

@Zen-Maxi
Copy link
Collaborator

Reviewed this compared to the dune dashboard. Everything matches to me.

SHAKOTN
SHAKOTN previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@SHAKOTN SHAKOTN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared line by line with dune dash:
https://dune.com/queries/2990731

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

File name: BIPs/00batched/2023-W38/BIP-431-airdrop.json
COMMIT: b355f7de52c39cf2f37ae2a2821654fcf4c9ab79
CHAIN(S): arbitrum

+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| function   | token_symbol                                    | recipient                                      | amount                        | bip     |   tx_index |
+============+=================================================+================================================+===============================+=========+============+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc59a1a2ed72Eb7B31b8eaEdAB1f6f8D8c8881365 | 3187.040443 (RAW: 3187040443) | BIP-431 |          0 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xd56e9F604ba364d5Df09730afcF946845ACe6683 | 2715.625111 (RAW: 2715625111) | BIP-431 |          1 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5C866C6ae5187130C234BC474A9fd55e3ea0Ac5D | 1744.260251 (RAW: 1744260251) | BIP-431 |          2 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xE356E05c77c4Df64FFd033432b969E229980F28b | 1578.0 (RAW: 1578000000)      | BIP-431 |          3 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5a407865411253E5A991d3e49E8Bc7A1FdBE82B0 | 1262.081183 (RAW: 1262081183) | BIP-431 |          4 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc407D9993b29F0aDA4a98686F134C78567D0F562 | 1200.0 (RAW: 1200000000)      | BIP-431 |          5 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xF7401728edd23290d8099eD73f155101dCf8CC0C | 1121.482439 (RAW: 1121482439) | BIP-431 |          6 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xc4F91e9d571D1366551E01056a1C8a2B8b01F8Ec | 1012.546862 (RAW: 1012546862) | BIP-431 |          7 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x1a7c7F0C3deFe3818A0a8d90b41573546717f145 | 429.375872 (RAW: 429375872)   | BIP-431 |          8 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x8484e288b7C2Edad1b5214ed9Df3BaE4af7dadf5 | 147.906745 (RAW: 147906745)   | BIP-431 |          9 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x1928c92C7b9d9A9699776f9Fb57aD6C84b44bE33 | 108.30214 (RAW: 108302140)    | BIP-431 |         10 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5614c860bfcB8d8Ea59E14c8aeE0b3F73511Cd5B | 96.394942 (RAW: 96394942)     | BIP-431 |         11 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xe69e85B87E46Ff35B32bD93aa5E9cf0a09B1c221 | 86.010151 (RAW: 86010151)     | BIP-431 |         12 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xA24D30Dd8cEC57A8be66f7359c7CCed581Df29Ed | 71.99547 (RAW: 71995470)      | BIP-431 |         13 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xFf4F7b726eE86f810531d2842B3BDd8A512dB594 | 67.914668 (RAW: 67914668)     | BIP-431 |         14 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x83E92a956c551BEc407d83e17f4317d9771466c3 | 66.156207 (RAW: 66156207)     | BIP-431 |         15 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x82b417bA7dAf38C496435E23e7714B5860C1C85F | 64.244563 (RAW: 64244563)     | BIP-431 |         16 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x53Cfd45B8416322a72009BcF0F57f54d906D947b | 60.076408 (RAW: 60076408)     | BIP-431 |         17 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xBC0b4983f6375b25ae7d0f8f56d029Cc24f78D05 | 40.248605 (RAW: 40248605)     | BIP-431 |         18 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x73e47E110dD251bd6449381724F2BB51C11b14BC | 21.6671 (RAW: 21667100)       | BIP-431 |         19 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x4624C8BDe33545893BaC01a999DDa0F9296B3588 | 19.184894 (RAW: 19184894)     | BIP-431 |         20 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x3D631a345B1b45Bf8A1456e43F91267304d5E048 | 15.997492 (RAW: 15997492)     | BIP-431 |         21 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x5388A7f24e86c9c9D855A98C2F5a339AFA6a3acc | 12.279972 (RAW: 12279972)     | BIP-431 |         22 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x892faC1BeB41e5E4B44A21E2DbE238D92FF9564c | 6.718158 (RAW: 6718158)       | BIP-431 |         23 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x6D7Ac63Aaa7bA8925dcB3E44BE6355261dCF688f | 5.7236 (RAW: 5723600)         | BIP-431 |         24 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xEE49B4204275D1439d38aF53dDaFfA940b07F111 | 3.150087 (RAW: 3150087)       | BIP-431 |         25 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x40b1d8B0B7232eb3258a455445ECfb3813f13fb8 | 3.119999 (RAW: 3119999)       | BIP-431 |         26 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x125aD150043F25A8C0A09C8b82Ac2a26EaAC1400 | 1.868476 (RAW: 1868476)       | BIP-431 |         27 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0x75c9aA37a479d5EdF521A505D9b366B442c80Dac | 1.793849 (RAW: 1793849)       | BIP-431 |         28 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+
| transfer   | USDC:0xaf88d065e77c8cC2239327C5EDb3A432268e5831 | N/A:0xdf330Ccb1d8fE97D176850BC127D0101cBe4e932 | 1.395061 (RAW: 1395061)       | BIP-431 |         29 |
+------------+-------------------------------------------------+------------------------------------------------+-------------------------------+---------+------------+

@Tritium-VLK Tritium-VLK merged commit f83ff3a into main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHAKOTN SHAKOTN SHAKOTN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tritium-VLK @Zen-Maxi @SHAKOTN