chore: bump web3 dep
#636
Closed
chore: bump web3 dep
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tritium-VLK
reviewed
Nov 22, 2023
|
not sure i follow your comments. im happy to not make changes, but can you specify the python version that was used for this current config then? 3.11 fails due to the mentioned bug in |
|
ah i see now that the action scripts are running in ci, and there they run in 3.9: https://github.com/BalancerMaxis/multisig-ops/blob/main/.github/workflows/run_auth_gen.yaml i ran them locally, but then there is no python version defined anywhere and my env defaulted to 3.11. set my python to 3.9 locally and all works without this fix being needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for python 3.11 as per ethereum/web3.py#2699