Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

유저 에러 핸들링 안되는 버그 수정 #417

Merged
merged 3 commits into from
Sep 20, 2023
Merged

유저 에러 핸들링 안되는 버그 수정 #417

merged 3 commits into from
Sep 20, 2023

Conversation

SEOKKAMONI
Copy link
Member

@SEOKKAMONI SEOKKAMONI commented Sep 19, 2023 •
edited
Loading

📄 Summary

유저 에러 핸들링 안되는 버그를 수정하였습니다


🔨 Tasks

  • 유저 에러 핸들링 안되는 버그 수정

🙋🏻 More

데이터 보내주는 방식이 달라져서 에러 핸들링이 안되었던거였숩니당

2023-09-20.12.24.45.mov

@SEOKKAMONI SEOKKAMONI added the ✨ Feature 새로운 기능 개발 label Sep 19, 2023
@SEOKKAMONI SEOKKAMONI self-assigned this Sep 19, 2023
@SEOKKAMONI SEOKKAMONI linked an issue Sep 19, 2023 that may be closed by this pull request
유저 에러 핸들링 안되는 버그 수정 #406
Closed
1 task
@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 10:35pm
maru-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 10:35pm

@github-actions
Copy link

이렇게 리뷰해주세요.

🖐️ 규칙

  1. 왜 개선이 필요한지 충분히 설명해주세요.
  2. 답을 알려주기보다는 스스로 고민하고 개선 방법을 선택할 수 있게 해주세요.
  3. 코드를 깔끔하게 유지하고, 일관되게 구현하도록 안내해 주세요.
  4. 리뷰 과정이 숙제검사가 아닌 학습과정으로 느낄 수 있게 리뷰해 주세요.
  5. 리뷰를 위한 리뷰를 하지 마세요. 피드백 할 게 없으면 칭찬해 주세요.

🥬 우선순위

리뷰 중요도에 따라 다음과 같은 prefix를 붙여주세요.

예시 - P5) 쓸모없는 주석 삭제해주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@SEOKKAMONI SEOKKAMONI requested a review from arkk200 September 19, 2023 08:43
@SEOKKAMONI SEOKKAMONI changed the title 유저 부분 에러 핸들링 안되는 버그 수정 에러 핸들링 안되는 버그 수정 Sep 19, 2023
@SEOKKAMONI SEOKKAMONI changed the title 에러 핸들링 안되는 버그 수정 유저 에러 핸들링 안되는 버그 수정 Sep 19, 2023
arkk200
arkk200 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@arkk200 arkk200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error 객체의 response가 있어야만 메시지가 작동되도록 만드셨네요👍

apps/user/src/hooks/useApiError.ts Outdated Show resolved Hide resolved
@SEOKKAMONI SEOKKAMONI requested a review from arkk200 September 19, 2023 22:32
arkk200
arkk200 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@arkk200 arkk200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영상 찍어서 보여주세요~

arkk200
arkk200 requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@arkk200 arkk200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자가 없다는 에러 메시지는 전에도 말했듯이 보안에 위험이 있을 수 있어요.
똑같이 로그인할 수 없다는 메시지를 보여줘야 할 것 같아요

arkk200
arkk200 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@arkk200 arkk200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 고쳤네요👍

@SEOKKAMONI SEOKKAMONI merged commit 1cb5a05 into develop Sep 20, 2023
@SEOKKAMONI SEOKKAMONI deleted the feat/#406 branch October 29, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkk200 arkk200 arkk200 approved these changes

Assignees

@SEOKKAMONI SEOKKAMONI

Labels
✨ Feature 새로운 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

유저 에러 핸들링 안되는 버그 수정
2 participants
@SEOKKAMONI @arkk200