Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthWrapper 리팩토링 #436

Merged
merged 2 commits into from
Sep 27, 2023
Merged

AuthWrapper 리팩토링 #436

merged 2 commits into from
Sep 27, 2023

Conversation

SEOKKAMONI
Copy link
Member

@SEOKKAMONI SEOKKAMONI commented Sep 27, 2023

📄 Summary

AuthWrapper에 개선점이 보여서 리팩토링을 하였습니다


🔨 Tasks

  • AuthWrapper 리팩토링

🙋🏻 More

@SEOKKAMONI SEOKKAMONI added the 🔨 Refactor 코드 리팩토링 label Sep 27, 2023
@SEOKKAMONI SEOKKAMONI requested a review from arkk200 September 27, 2023 00:19
@SEOKKAMONI SEOKKAMONI self-assigned this Sep 27, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:13am
maru-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 1:13am

@github-actions
Copy link

이렇게 리뷰해주세요.

🖐️ 규칙

  1. 개선이 필요한지 충분히 설명해주세요.
  2. 답을 알려주기보다는 스스로 고민하고 개선 방법을 선택할 수 있게 해주세요.
  3. 코드를 깔끔하게 유지하고, 일관되게 구현하도록 안내해 주세요.
  4. 리뷰 과정이 숙제검사가 아닌 학습과정으로 느낄 수 있게 리뷰해 주세요.
  5. 리뷰를 위한 리뷰를 하지 마세요. 피드백 할 게 없으면 칭찬해 주세요.

🥬 우선순위

리뷰 중요도에 따라 다음과 같은 prefix를 붙여주세요.

예시 - P5) 쓸모없는 주석 삭제해주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

Copy link
Contributor

@arkk200 arkk200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알맞게 옮겼네요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthWrapper 리팩토링
2 participants