This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Creates a base container providing request metadata #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendamere
force-pushed
the
metadata/provide-metadata
branch
3 times, most recently
from
bcd1af7 to
3b9053a
Compare
invadergir
reviewed
Dec 7, 2022
| object CosmosContainer { | ||
|
|
||
| private class IMapKCosmosContainer[F[_], G[_], Key, Id, StreamResult[_], QueryValue, SingleResult[ | ||
| _ |
invadergir
approved these changes
Dec 7, 2022
peterneyens
reviewed
Dec 8, 2022
| .iterable(elements.asScala) | ||
| .traverse(jacksonToCirce(_).as[A]) | ||
| .fold(Stream.raiseError[F] _, Stream.chunk(_)) | ||
| .evalMapFilter { |
There was a problem hiding this comment.
This will break up the Chunks that correspond to the pages. Tthat is why we traversed the Chunk directly before.
Similar for handleResultMeta.
There is evalMapChunk that preservers chunks by traversing the chunk, but there is no equivalent for evalMapFilter, maybe we need to define that ourselves here?
(we had a similar issue before in #75)
There was a problem hiding this comment.
I replaced it with a collect and evalMapChunk.
peterneyens
reviewed
Dec 8, 2022
| .fold(Stream.raiseError[F], Stream.chunk) | ||
| Stream.exec(handleDiagnostics(page.getCosmosDiagnostics())) ++ stream | ||
| .handleDiagnostics(handleDiagnostics) | ||
| .evalMap { json => |
There was a problem hiding this comment.
We probably want evalMapChunk here (but for it to be useful handleDiagnostics would need to preserver the chunks as well)
vendamere
force-pushed
the
metadata/provide-metadata
branch
from
3b9053a to
a34641e
Compare
peterneyens
approved these changes
Dec 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Raw and Indexed containers to use the base container
Removes partition key from upsert function in indexed container that isn't used or applicable.