Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): t_string_async macro example correct implementation #170

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Dec 16, 2024

No description provided.

@sabify sabify changed the title fix(docs): t_string_async macro example corret implementation fix(docs): t_string_async macro example correct implementation Dec 16, 2024
@Baptistemontan
Copy link
Owner

Baptistemontan commented Dec 17, 2024

I know it's a macro but it is still an example, I wanted it to be readable or I would have simply exported it from the library.
Your modifications also lack consistencies, why not also have leptos::prelude::AsyncDerived ?
The $ is indeed missing, but I don't think the , is needed.
And thanks for the typo!

@sabify
Copy link
Contributor Author

sabify commented Dec 17, 2024

Without catching , ident, it's not possible to pass arguments like t_string_async!(i18n, app_name) and the compiler returns error.

@Baptistemontan
Copy link
Owner

Without catching , ident, it's not possible to pass arguments like t_string_async!(i18n, app_name) and the compiler returns error.

Ho ok I didn't knew that, thanks !

@Baptistemontan Baptistemontan merged commit e6ea93b into Baptistemontan:master Dec 17, 2024
28 checks passed
@sabify sabify deleted the doc-asyncc branch December 17, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants