Fix azurerm terraform provider for base workspace, guacamole, and windows VM #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyWildish-BH
added
bug
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4cc88ae. |
BIOKU-BH
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue 4095 in https://github.com/microsoft/AzureTRE/issues/
What is being addressed
See the above report for details. Microsoft have deprecated a resource, which broke the Terraform providers we're using. They're all over the map anyway, and many of them are very old. Very poor version hygiene.
How is this addressed
It's enough to update the
provider.tfentry for theazurermresource provider in most resources, and remove/re-create the.terraform.lock.hclfile. Some features need more advanced effort, again, see the above ticket.At some point soon, when the PR from CloudKubed has been merged and tested (by other people!), we should update our codebase with those same changes. That's a lot of files that get touched, so it shouldn't wait too long.