Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation docker for production deploy #1429

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antoineludeau
Copy link
Member

@antoineludeau antoineludeau commented Feb 7, 2023

This pull request aims to prepare implementation of the adresse.data.gouv docker image for production by :

  • Defining the production image (Dockerfile)
  • Defining the github workflow to build and push the image in the Docker Hub, the job being triggered at each push in the 'master' branch (and so, during each merge into master)

What still need to to done (that's why the pull request is still in DRAFT mode) :

  • Create a BAN registry in DockerHub (example: ban/adressedatagouv). We can create a free Docker Hub account for the BAN open source community (limit = 200 container image requests per six hours).
  • Add github secret to login to the docker hub registry : DOCKERHUB_USERNAME and DOCKERHUB_TOKEN

That done, the only command that will need to be started on the ban-server will be :

docker run -p 5100:5100 --env-file ./app-env ban/adressedatagouv

Comments on the above command
-p 5100:5100 = mapping inner docker container port 5100 to external port 5100
--env-file ./app-env = Inject env variable from the file 'app-env' (file can have another name)

@antoineludeau antoineludeau marked this pull request as draft February 7, 2023 10:20
@antoineludeau antoineludeau changed the title Implementation docker for production Implementation docker for production deploy Feb 7, 2023
@antoineludeau antoineludeau force-pushed the antoineludeau/implementation-docker-production branch from 8eb4b66 to e3a9e2f Compare February 13, 2023 18:58
@antoineludeau antoineludeau force-pushed the antoineludeau/implementation-docker-production branch from e3a9e2f to 1dff432 Compare February 20, 2023 14:01
@antoineludeau antoineludeau self-assigned this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant