Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded CI node version to 16, 18 and 20 on github action workflow #1484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antoineludeau
Copy link
Member

@antoineludeau antoineludeau commented Apr 5, 2023

Context :

In the goal of making adresse.data.gouv fully compatible with node version 16, 18 and 20 we need to upgrade the CI to run on the same desired node version.

Enhancements :
This PR aims to :

Modify node version in CI to a matrix of 3 versions : 16, 18 and 20,
Modify "engine" field in package.json to specify on which node version adresse.data.gouv can run on.

@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch 3 times, most recently from 701fb25 to ff6c8b5 Compare April 5, 2023 15:42
@antoineludeau antoineludeau self-assigned this Apr 5, 2023
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from ff6c8b5 to e9e885e Compare April 12, 2023 09:51
@antoineludeau
Copy link
Member Author

En attente de upgrader le serveur sur node 18 avant de merger.

@antoineludeau antoineludeau marked this pull request as draft June 6, 2023 09:18
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from e9e885e to 210c695 Compare October 10, 2023 13:46
@antoineludeau antoineludeau marked this pull request as ready for review October 10, 2023 13:47
@antoineludeau antoineludeau changed the title Upgrade node version GitHub action workflow Upgraded CI node version to 16, 18 and 20 on github action workflow #117 Oct 10, 2023
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from 210c695 to 21651a7 Compare October 10, 2023 13:51
@antoineludeau antoineludeau changed the title Upgraded CI node version to 16, 18 and 20 on github action workflow #117 Upgraded CI node version to 16, 18 and 20 on github action workflow Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants