Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bashit upgrade function git log and add missing popd #2139

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Mar 21, 2022

Description

Having merge logs with actual changes was too noisy. So in this PR, it will be removed and actual commits will be shown. Also when the upgrade fails, the directory doesn't change back to the source directory, rather it stayed in $BASH_IT directory. So I have also added popd just before returning the function.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thank you @tbhaxor !

@NoahGorny NoahGorny merged commit b950941 into Bash-it:master Apr 6, 2022
@tbhaxor tbhaxor deleted the patch-3 branch April 7, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants