bug: Use en_US when fetching EPOCHREALTIME

[davidpfarrell]

Isolates fetching of EPOCHREALTIME to a function which sets LC_ALL=en_US.UTF-8.
This ensures that the value is in decimal format, regardless of runtime locale.

Motivation and Context

fixes #2171

How Has This Been Tested?

Tested locally

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[davidpfarrell]

@PinheiroCosta Can you test this branch in your local and report back on how it goes?

[PinheiroCosta]

@PinheiroCosta Can you test this branch in your local and report back on how it goes?

Thank you @davidpfarrell, it's working fine now. Check it out:

[davidpfarrell]

@PinheiroCosta thanks for confirming!

Quick Q: I don't use duration, can you tell me if this is normal/expected?

Seems like if I don't run any commands then I shouldn't see any duration report ...
This also breaks the cmd-returns plugin as, once the value gets above 5, it beeps on every return.

What happens in your local if you just keep pressing enter for several seconds?

[PinheiroCosta]

I believe this happens because the command is computing something like (timestamp_the_last_command_started - now).
When we press the enter key several times, the last command is still running. If we alternate pressing enter key several times with some random commands, this is what we get:

In my opinion, this shouldn't happen cause it may confuse some devs.

Edit: I don't consider it a bug, but it should be improved. Maybe we should open an enhancement issue for that?

[davidpfarrell]

@PinheiroCosta Thanks for confirming I wasn't the only one seeing the behavior.

I don't consider it a bug, but it should be improved

So you'll see I just added a commit which prevents duration from showing when you "just press enter" without running a command.

There are a few pieces to the fix, but the key is this line here :

_bash_it_library_finalize_hook+=("safe_append_prompt_command '_command_duration_pre_cmd'")

If you like you can change this in your local (assuming you're on this PR branch) to be this:

_bash_it_library_finalize_hook+=("safe_append_prompt_command '_command_duration_pre_exec'")

With this change, pressing enter will show how long the prompt has been idle. ie. if you wait 5 seconds and press enter, it will show 5s, if you wait 10 seconds to press enter, it will show 10s, etc ...

For me, showing anything when you "just press enter" on a blank prompt is a bug, so I'm happy with this fix as part of the PR.

If you decide you truly need to know how long you're prompt has been idle, feel free to submit an enhancment PR after this merges -- maybe we can support an extra env variable to switch between the two behaviors ...

[PinheiroCosta]

Hey @davidpfarrell, awesome solution you've elaborated. I usually measure how long my prompt has been idle by activating the time stamp on the prompt. This additional commit has not just solved my problem but also improved the tool I enjoy using. Thank you!!

[NoahGorny]

Great fix @davidpfarrell !