Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning spending datasets from us spending #29

Merged
merged 12 commits into from
Oct 23, 2023

Conversation

Niklewa
Copy link
Collaborator

@Niklewa Niklewa commented Oct 20, 2023

No description provided.

@Niklewa Niklewa requested a review from rfl-urbaniak October 20, 2023 11:35
Copy link
Contributor

@rfl-urbaniak rfl-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add zeroes for control
  • make sure the number of unique units is the same across all datasets, including gdp
  • add unique fips code counting for all datasets to the tests

cities/utils/clean_spending_HHS.py Outdated Show resolved Hide resolved
cities/utils/clean_transport.py Show resolved Hide resolved
@Niklewa
Copy link
Collaborator Author

Niklewa commented Oct 21, 2023

  • add zeroes for control

    • make sure the number of unique units is the same across all datasets, including gdp

    • add unique fips code counting for all datasets to the tests

All done, testing works

@rfl-urbaniak rfl-urbaniak merged commit 40808fa into ru-add-fed-and-features Oct 23, 2023
@rfl-urbaniak rfl-urbaniak deleted the nl-add-transportation-spendings branch October 23, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants