-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the overlay command in Bastillefile #231
Conversation
I'm the one responsible for creating these bugs. The intention was to create a As for the missing slash, I was providing a destination path in my testing:
I see why supporting no 2nd parameter for backward compatibility makes sense, but it would be great to also support a 2nd parameter to have the ability to specify a destination. It's kind of a pain to implement taking different possibilities into consideration: 1 param or 2, either/both of them quoted with spaces, either/both having a leading slash. This function seems to work, but please double check me:
Then you have to call it using eval to parse the single string containing both paths into 2 strings:
Would you mind using that or something similar to get both working? |
Would it help to merge this if I implement it like you described above? |
It doesn't need to be implemented like above but we should support both |
@chriswells0 Would you mind looking at this again. I fixed it very basic right now for two reasons:
With this one copy needs two arguments, and overlay one. Also, I added an alias |
I think this looks pretty good. "Basic" is (usually) the goal. |
Sorry for the delay: going through some busy times. Thanks for keeping the 2-parameter version of |
The documentation did mention that
OVERLAY
should be used, but onlycp
was implemented.Also the destination part where to copy the files to has been missing.
The previous hooks seem to implement it in a similar way: https://github.com/BastilleBSD/bastille/blob/master/usr/local/share/bastille/template.sh#L175