[WIP] [feedback required] Improve dualstack and IPv6 support on jail creation #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still WIP / PoC and would require documentation changes, opening PR to gather feedback as this is a first-time contribution. Important changes: - instead of relying on 0.0.0.0 to signal DHCP, we now support passing "DHCP" in the IP parameter. - we also support "SLAAC" as a value for the IP parameter, which enables accepting route advertisement - fixed an oddity in the way the gateway was being handled for IPv6 (in certain cases it was being passed as the GATEWAY template parameter - allow passing multiple values to the IP parameter, this would work as a quoted parameter - that means that, e.g. bastille create -V test 13.0-RELEASE "SLAAC DHCP" wan is possible and creates a dual-stack jail - passing both DHCP, SLAAC and fixed IPs is also possible, but only one IP per protocol number is supported; last one wins
evilham
force-pushed
the
evilham-improve-ipv6-and-dualstack-creation
branch
from
9adfe0f
to
f6f179b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP / PoC and would require documentation changes, opening PR to
gather feedback as this is a first-time contribution.
Important changes:
the IP parameter.
accepting route advertisement
cases it was being passed as the GATEWAY template parameter
parameter
possible and creates a dual-stack jail
protocol number is supported; last one wins