Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs.sh - add * to case command #774

Closed
wants to merge 2 commits into from

Conversation

tschettervictor
Copy link
Collaborator

No description provided.

@tschettervictor
Copy link
Collaborator Author

@bmac2 @yaazkal

If its ok with you guys, I'm going to go through each bastille script and see if anything can be streamlined or fixed or even improved somewhat.

Wondering on your thoughts?

Most things like zfs.sh here are fine, but need some additional things like this PR.

@bmac2
Copy link
Collaborator

bmac2 commented Dec 27, 2024

What is use case for this?
How do I test it?

@tschettervictor
Copy link
Collaborator Author

It's simply if you do "bastille zfs blabla" it should error exit.

It's to filter out all non commands.

@bmac2
Copy link
Collaborator

bmac2 commented Dec 27, 2024

acts the same for me before and after. So no change in what I see. What am I doing wrong?

@tschettervictor
Copy link
Collaborator Author

My bad. It should be.

bastille zfs jail blablabla

As opposed to the regular commands.

@bmac2
Copy link
Collaborator

bmac2 commented Dec 27, 2024

still no changes so it acts the same with both the original zfs.sh and the new zfs.sh

@bmac2
Copy link
Collaborator

bmac2 commented Dec 27, 2024

root@fbsd:/usr/local/share/bastille # bastille zfs jail blabla
[jail]: Not found.
root@fbsd:/usr/local/share/bastille # bastille zfs jail3 blahblah
Usage: bastille zfs TARGET [set|get|snap] [key=value|date]'
root@fbsd:/usr/local/share/bastille # mv zfs.sh new.zfs.sh
root@fbsd:/usr/local/share/bastille # cp old.zfs.sh zfs.sh
root@fbsd:/usr/local/share/bastille # bastille zfs jail3 blahblah
Usage: bastille zfs TARGET [set|get|snap] [key=value|date]'
root@fbsd:/usr/local/share/bastille #

@tschettervictor
Copy link
Collaborator Author

On mine it just doesn't do anything with the original. But with this changes the help message shows up...

@tschettervictor
Copy link
Collaborator Author

Skip this one. I think I opened it before doing the new functions. Thats probably what going on.

Let's move on to the other PRs.

@tschettervictor tschettervictor deleted the patch-8 branch December 27, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants