Do exact boss name matching in OnSpecialSelected #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The story:
We use hidden spawning plugin which spawns hidden bosses randomly, the plugin was made for FF2Bat. When one of the hidden bosses spawns,
characterNamewas set to for examplehiddens/supremex10(aka the path to the boss config) and everything worked fine.The same plugin was tested on FF2R and It didn't work correctly, hidden boss will randomly not get forced. It seems FF2R only checks the
nameof the boss. Ok, then. I modified the plugin to setcharacterNameto exact boss name. Tested and it also didn't work all the time. Fine. More code checking and it seemsOnSpecialSelecteduses inexact boss name matching. So I switched second argument totrueSo there's the pull request, do exact boss name checking in
OnSpecialSelected.